Skip to content

[ExecutionEngine] Include <map> #124083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

[ExecutionEngine] Include <map> #124083

merged 2 commits into from
Jan 23, 2025

Conversation

@kazutakahirata
Copy link
Contributor

@kazutakahirata kazutakahirata commented Jan 23, 2025

This patch reinstates an include of , fixing a build failure
caused by:

commit 1f4d91e
Author: Kazu Hirata [email protected]
Date: Tue Nov 19 19:41:59 2024 -0800

[ExecutionEngine] Remove unused includes (NFC) (#116749)

@kazutakahirata
[ExecutionEngine] Include <map>
c6e9fd8 
This patch reinstates an include of <map>, fixing a build failure
caused by:

  commit 1f4d91e
  Author: Kazu Hirata <[email protected]>
  Date:   Tue Nov 19 19:41:59 2024 -0800

  [ExecutionEngine] Remove unused includes (NFC) (llvm#116749)
@kazutakahirata kazutakahirata mentioned this pull request Jan 23, 2025
Closed
@kazutakahirata
Copy link
Contributor Author

kazutakahirata commented Jan 23, 2025

@h-vetinari, you may not have commit access, but textual "LGTM" would be appreciated. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

h-vetinari
h-vetinari approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

h-vetinari
h-vetinari reviewed Jan 23, 2025
View reviewed changes
@kazutakahirata kazutakahirata merged commit bda39a6 into llvm:main Jan 23, 2025
8 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_restore_map branch January 23, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-vetinari h-vetinari h-vetinari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kazutakahirata @h-vetinari